Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add CI coverage #451

Merged
merged 1 commit into from
May 7, 2024
Merged

Add CI coverage #451

merged 1 commit into from
May 7, 2024

Conversation

vladbochok
Copy link
Member

What ❔

Why ❔

Checklist

  • PR title corresponds to the body of PR (we generate changelog entries from PRs).
  • Tests for the changes have been added / updated.
  • Documentation comments have been added / updated.

@vladbochok vladbochok changed the base branch from main to sb-update-canonical-bytecode May 7, 2024 13:57
@github-actions GitHub Actions
Copy link

github-actions bot commented May 7, 2024

Coverage after merging vb-add-ci-cov-foundry into sb-update-canonical-bytecode will be

85.50%

Coverage Report
FileStmtsBranchesFuncsLinesUncovered Lines
contracts/bridge
   L1ERC20Bridge.sol81.82%80%75%84.62%60, 68, 68, 68–70
   L1SharedBridge.sol81.45%75.83%79.41%85.98%100, 109, 115, 115, 115, 127–131, 145, 152, 163–164, 171, 171, 171–175, 175, 175–176, 181–183, 183, 183–186, 186, 186–187, 199, 206, 206, 206, 328–329, 445, 451, 466, 475, 492, 575, 581, 636, 808, 813, 94
contracts/bridgehub
   Bridgehub.sol81.97%60.53%89.47%92.31%126–127, 129, 133–134, 136, 221–222, 268–269, 275, 275, 275–276, 298, 302, 333, 338, 43, 65
contracts/common
   ReentrancyGuard.sol100%100%100%100%
contracts/common/libraries
   L2ContractHelper.sol53.57%30%50%71.43%23, 26–27, 40–41, 41, 41, 43, 43, 43, 50
   UncheckedMath.sol100%100%100%100%
   UnsafeBytes.sol100%100%100%100%
contracts/governance
   Governance.sol91.67%93.75%95%89.29%42, 42, 42, 44, 46–47, 49–50
contracts/state-transition
   StateTransitionManager.sol62.96%55.56%50%68.97%140, 150, 152–153, 158–159, 159, 159, 161–163, 165–166, 208, 228, 242, 247, 252, 257, 262, 267, 272, 335, 335, 335, 337, 400, 83, 83, 83, 89–92, 98
   TestnetVerifier.sol40%25%50%50%16, 16, 16, 28, 32
   ValidatorTimelock.sol93.75%100%94.74%91.43%58–60
   Verifier.sol100%100%100%100%
contracts/state-transition/chain-deps
   DiamondInit.sol87.76%70%100%100%25–29, 52
   DiamondProxy.sol70.59%62.50%100%75%14, 14, 14–15, 25
contracts/state-transition/chain-deps/facets
   Admin.sol86.05%72.73%92.31%90.20%124, 151–152, 154, 74, 83, 95, 95, 95–97
   Executor.sol88.67%80%84.38%95.79%118, 183, 186, 192, 194–197, 208, 226, 240, 298, 355, 375–377, 397, 40, 438, 445, 464, 469, 52, 52, 530, 54, 54, 54, 555–556, 58, 60, 604, 606, 61, 666
   Getters.sol93%75%92.50%94.64%169, 194, 68, 73
   Mailbox.sol65.45%50%58.82%73.13%106, 116, 116, 116, 118, 124, 124, 124, 130–131, 133, 138–139, 165, 194, 194, 194–195, 215, 260, 271, 277, 45, 45, 45, 47–49, 66, 76, 98
   ZkSyncHyperchainBase.sol82.14%78.57%85.71%85.71%46, 54, 54, 54
contracts/state-transition/libraries
   Diamond.sol94.33%84.09%100%98.85%107, 113, 116, 181, 236, 265, 284, 286
   LibMap.sol100%100%100%100%
   Merkle.sol100%100%100%100%
   PriorityQueue.sol100%100%100%100%
   TransactionValidator.sol97.18%94.12%100%100%52–53
contracts/upgrades
   BaseZkSyncUpgrade.sol56%33.33%91.67%60.34%102–103, 109, 113, 116, 119–120, 130, 134–136, 146, 154–156, 185–186, 189, 204, 222–223, 226, 226, 226, 236–237, 237, 237, 241, 241, 241, 248, 248, 248–249, 249, 249, 254–255, 71, 92, 96, 99
   BaseZkSyncUpgradeGenesis.sol75%50%100%100%16, 21, 27–28
   DefaultUpgrade.sol0%100%0%0%14–15
   GenesisUpgrade.sol100%100%100%100%
   UpgradeHyperchains.sol0%0%0%0%16, 23–24, 24, 24–25, 25, 25–26, 26, 26–27, 27, 27–28, 28, 28–29, 29, 29, 31–39, 41–42
   Upgrade_v1_4_1.sol0%0%0%0%27, 27, 27, 29–30, 32, 39, 50, 52
contracts/vendor
   AddressAliasHelper.sol78.57%50%100%85.71%52, 58, 60

StanislavBreadless
StanislavBreadless approved these changes May 7, 2024
View reviewed changes
Copy link
Collaborator

@StanislavBreadless StanislavBreadless left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❤️

@vladbochok vladbochok merged commit 221f237 into sb-update-canonical-bytecode May 7, 2024
25 checks passed
@vladbochok vladbochok deleted the vb-add-ci-cov-foundry branch May 7, 2024 17:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@StanislavBreadless StanislavBreadless StanislavBreadless approved these changes

@saxenism saxenism Awaiting requested review from saxenism

@kelemeno kelemeno Awaiting requested review from kelemeno

@razzorsec razzorsec Awaiting requested review from razzorsec

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@vladbochok @StanislavBreadless